Uploaded image for project: 'The Virtual Brain'
  1. The Virtual Brain
  2. TVB-3038

SigmoidalJansenRit coupling default params

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.7.2
    • None
    • None

    Description

      There was a confusion between parameter "a" being the scaling inside the sigmoidal for all other sigmoidal coupling models, but not for the JR one, for which it is the parameter "r".

      So, I have:

      • set default r = 0.56,
      • default a = 1.0 like in the rest of the sigmoidal couplings,
      • and changed the docstring to use r instead of a.

      Moreover, I added the cmin (with default 0.0) in the pre() equation method in order to match the docstring. It was missing before.

      Finally, in the JR model there is an unnecessary repetition of the multiplication 2 * nu_max parameter. We should consider to absorb this either in the parameter or as a derived parameter to be initialized once during the model.configure(), in a future PR. Please comment on this prospect.

      See in the attached image the difference r = 0.56 against r=1.0 makes. Not big, but it is something to consider, especially how many people use the model without noticing it.

       

       

      See description and proposed fix here:

      https://github.com/the-virtual-brain/tvb-root/pull/605

       

      Gliffy Diagrams

        Attachments

          Activity

            People

              dionysios.perdikis Dionysios Perdikis
              dionysios.perdikis Dionysios Perdikis
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours Time Not Required
                  2h