Uploaded image for project: 'The Virtual Brain'
  1. The Virtual Brain
  2. TVB-3023

Neotraits mutable default behaves unexpected

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.0, 2.6
    • 2.7
    • None
    • None
    • VBC Sprint 14
    • 8.2 Pipeline Integration

    Description

      integrators.IntegratorStochastic.noise.default =noise.Additive()

      Unless we change this field when we configure a simulation, this class belonging default instance will be used for further instances of Simulator (which take the default noise).

      This was revealed by this PR https://github.com/the-virtual-brain/tvb-root/pull/578

      To reproduce it: this will fail in tvb-library 2.6, but we expect it to pass:

          sim = simulator.Simulator(
                  connectivity=con,
                  coupling=coupling.Linear(a=numpy.array([2e-4])),
                  integrator=integrators.EulerStochastic(dt=10.0),
                  model=models.Linear(gamma=numpy.array([-1e-2])),
                  monitors=(monitors.Raw(),),
                  simulation_length=60e3
          )
      
          assert sim.integrator.noise != integrators.IntegratorStochastic.noise.default
      

       

      Gliffy Diagrams

        Attachments

          Issue Links

            Activity

              People

                lia.domide Lia Domide
                paula.popa Paula Prodan
                Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved:

                  Time Tracking

                    Estimated:
                    Original Estimate - 1 day
                    1d
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 4 hours, 30 minutes Time Not Required
                    4h 30m