Uploaded image for project: 'The Virtual Brain'
  1. The Virtual Brain
  2. TVB-2663

Remove imports of "tvb.adapters" from "tvb.core"

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.7
    • Component/s: None
    • Labels:
      None

      Description

      Currently, searches of string "tvb.adapters" reveals about 7 imports of this module under "tvb.core".

      This should never happen, adapters depend on core and not in reverse.

      Usages in code_updates_scripts or db_updates scripts should not be counted. Those are ok-ish.

      We need to decide individually on each import how to fix this back dependency:

      • move the class from adapters into core?
      • pass as parameter the reference from adapters into the core method?
      • other solution

        Gliffy Diagrams

          Attachments

            Activity

              People

              Assignee:
              bogdan.valean Bogdan Valean
              Reporter:
              lia.domide Lia Domide
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 2 days Original Estimate - 2 days
                  2d
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 1 hour
                  2d 1h